Why doesn't Android use more enums?

AndroidEnums

Android Problem Overview


I've started to really like using C# and Java enums in my code for several reasons:

  • They are much more type-safe than integers, strings, or sets of boolean flags.
  • They lead to more readable code.
  • It's more difficult to set an enum to an invalid value than an int or string.
  • They make it easy to discover the allowed values for a variable or parameter.
  • Everything I've read indicates that they perform just as well as integers in C# and most JVMs.

However, the Android framework has numerous cases where flags of various types need to be passed around, but none of them seem to use enums. A couple of examples where I would think their use would be beneficial are Toast.LENGTH_SHORT / Toast.LENGTH_LONG and View.GONE, View.VISIBLE, etc.

Why is this? Do enums perform worse than simple integer values in Dalvik? Is there some other drawback I'm not aware of?

Android Solutions


Solution 1 - Android

This answer is out of date as of March 2011.

Enums can be used on Froyo and up - according to this answer (Why was “Avoid Enums Where You Only Need Ints” removed from Android's performance tips?) from a member of the Android VM team (and his blog).


Previous Answer:

The official Android team recommendation is to avoid enums whenever you can avoid it:

> Enums are very convenient, but > unfortunately can be painful when size > and speed matter. For example, this: > public enum Shrubbery { GROUND, CRAWLING, HANGING }

> adds 740 bytes to > your .dex file compared to the > equivalent class with three public > static final ints. On first use, the > class initializer invokes the > method on objects representing each of > the enumerated values. Each object > gets its own static field, and the > full set is stored in an array (a > static field called "$VALUES"). That's > a lot of code and data, just for three > integers. Additionally, this: > Shrubbery shrub = Shrubbery.GROUND; > > causes a static field lookup. If > "GROUND" were a static final int, the > compiler would treat it as a known > constant and inline it.

Source: Avoid Enums Where You Only Need Ints

Solution 2 - Android

Integers are smaller, and require less overhead, something that still matters on mobile devices.

Solution 3 - Android

A colleague of mine performed a small test regarding this situation. He auto generated a class and an enum with the same amount of "enums". I believe he generated 30000 entries.

The results were:

  • .class for the class was roughly 1200KB
  • .class for the enum was roughly 800KB

Hope this helps someone.

Attributions

All content for this solution is sourced from the original question on Stackoverflow.

The content on this page is licensed under the Attribution-ShareAlike 4.0 International (CC BY-SA 4.0) license.

Content TypeOriginal AuthorOriginal Content on Stackoverflow
QuestionWe Are All MonicaView Question on Stackoverflow
Solution 1 - AndroidSebastian Paaske TørholmView Answer on Stackoverflow
Solution 2 - AndroidRussell SteenView Answer on Stackoverflow
Solution 3 - Androidprolink007View Answer on Stackoverflow