Why BigDecimal("5.50") not equals to BigDecimal("5.5") and how to work around this issue?

JavaEqualsBigdecimal

Java Problem Overview


Actually, I've found possible solution

//returns true
new BigDecimal("5.50").doubleValue() == new BigDecimal("5.5").doubleValue()

Of course, it can be improved with something like Math.abs (v1 - v2) < EPS to make the comparison more robust, but the question is whether this technique acceptable or is there a better solution?

If someone knows why java designers decided to implement BigDecimal's equals in that way, it would be interesting to read.

Java Solutions


Solution 1 - Java

From the javadoc of BigDecimal

>equals > >public boolean equals(Object x) > >Compares this BigDecimal with the specified Object for equality. Unlike compareTo, this method considers two BigDecimal objects equal only if they are equal in value and scale (thus 2.0 is not equal to 2.00 when compared by this method).

Simply use compareTo() == 0

Solution 2 - Java

The simplest expression to compare ignoring trailing zeros is since Java 1.5:

bd1.stripTrailingZeros().equals(bd2.stripTrailingZeros())

Solution 3 - Java

Using == to compare doubles seems like a bad idea in general.

You could call setScale to the same thing on the numbers you're comparing:

new BigDecimal ("5.50").setScale(2).equals(new BigDecimal("5.5").setScale (2))

where you would be setting the scale to the larger of the two:

BigDecimal a1 = new BigDecimal("5.051");
BigDecimal b1 = new BigDecimal("5.05");
// wow, this is awkward in Java
int maxScale = Collections.max(new ArrayList() {{ a1.scale(), b1.scale()}});
System.out.println(
  a1.setScale(maxScale).equals(b1.setScale(maxScale)) 
  ? "are equal" 
  : "are different" );

Using compareTo() == 0 is the best answer, though. The increasing of the scale of one of the numbers in my approach above is likely the "unnecessary inflation" that the compareMagnitude method documentation is mentioning when it says:

/**
 * Version of compareTo that ignores sign.
 */
private int compareMagnitude(BigDecimal val) {
    // Match scales, avoid unnecessary inflation
    long ys = val.intCompact;
    long xs = this.intCompact;

and of course compareTo is a lot easier to use since it's already implemented for you.

Attributions

All content for this solution is sourced from the original question on Stackoverflow.

The content on this page is licensed under the Attribution-ShareAlike 4.0 International (CC BY-SA 4.0) license.

Content TypeOriginal AuthorOriginal Content on Stackoverflow
QuestionRomanView Question on Stackoverflow
Solution 1 - JavaColin HebertView Answer on Stackoverflow
Solution 2 - Javauser1708042View Answer on Stackoverflow
Solution 3 - Javaпутин некультурная свиньяView Answer on Stackoverflow