Using DataBinding library for binding events
AndroidData BindingAndroid 6.0-MarshmallowAndroid DatabindingAndroid Problem Overview
I'm trying to bind events with views in xml using DataBinding Library shipped with Android M. I'm following examples from Android Developers and implementing step-by-step. for the view's attributes like visibility,text its working fine but if I try to bind with onclick, it doesn't work as expected. Here's the sample code that I've tried so far:
<data>
<import type="android.view.View"/>
<variable name="user" type="com.example.databinding.User"/>
<variable name="handlers" type="com.example.databinding.MyHandlers"/>
</data>
<TextView
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@{user.firstName}"
android:visibility="@{user.isFriend ? View.VISIBLE : View.GONE}" />
<Button
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="Click Me"
android:id="@+id/button"
android:layout_gravity="left"
android:onClick="@{handlers.onClickFriend}"/>
MainActivity :
public class MainActivity extends AppCompatActivity {
User user;
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
ActivityMainBinding binding =
DataBindingUtil.setContentView(this,R.layout.activity_main);
user = new User("Pankaj","Kumar",true,true);
binding.setUser(user);
}
}
MyHandlers:
public class MyHandlers {
public void onClickFriend(View view){
Log.i(MyHandlers.class.getSimpleName(),"Now Friend");
}
public void onClickEnemy(View view){
Log.i(MyHandlers.class.getSimpleName(),"Now Enemy");
}
}
I've written only required code to improve readability. Could someone help me on this.
Android Solutions
Solution 1 - Android
I think you will need to bind the handlers
as well, maybe something like this in onCreate
:
MyHandlers handlers = new MyHandlers();
binding.setHandlers(handlers);
Solution 2 - Android
Many Ways for setting Click
-
Pass handler to binding.
ActivityMainBinding binding = DataBindingUtil.setContentView(this,R.layout.activity_main); Hander handler = new Handler(); binding.setHandler(handler);
-
Set clicks (use any of below)
android:onClick="@{handler::onClickMethodReference}"
OR
android:onClick="@{handler.onClickMethodReference}"
OR
android:onClick="@{() -> handler.onClickLamda()}"
OR
android:onClick="@{(v) -> handler.onClickLamdaWithView(v)}"
OR
android:onClick="@{() -> handler.onClickLamdaWithView(model)}"
See Handler class for understanding.
public class Handler {
public void onClickMethodReference(View view) {
//
}
public void onClickLamda() {
//
}
public void onClickLamdaWithView(View view) {
//
}
public void onClickLamdaWithObject(Model model) {
//
}
}
Note that
- You can use Method Reference (::) when you have same argument as the attribute onClick.
- You can pass any object like
onClickLamdaWithObject
example. - If you need to pass
View
object then just use(v)->
expression.
Further reading
https://developer.android.com/topic/libraries/data-binding/expressions
Solution 3 - Android
Use this format in your xml:
android:onClick="@{handlers::onClickFriend}"
Pay attention to the ::
, do not worry about the red lines in xml editor, because is currently this is open bug for the Android Studio xml editor.
Where handlers
is your variable from data tag:
<data>
<variable name="handlers" type="com.example.databinding.MyHandlers"/>
</data>
and onClickFriend
is your method:
public class MyHandlers {
public void onClickFriend(View view) {
Log.i(MyHandlers.class.getSimpleName(),"Now Friend");
}
}
ADDED
For handle onLongClick
in xml add this:
android:onLongClick="@{handlers::onLongClickFriend}"
and add onLongClickFriend
method in your ViewModel class:
public class MyHandlers {
public boolean onLongClickFriend(View view) {
Log.i(MyHandlers.class.getSimpleName(),"Long clicked Friend");
return true;
}
}
ADDED
If you need to show toast message, you can use interface (better variant), or pass context
in the MyHandlers
class in construction:
public class MyHandlers {
public boolean onLongClickFriend(View view) {
Toast.makeText(view.getContext(), "On Long Click Listener", Toast.LENGTH_SHORT).show();
return true;
}
}
Solution 4 - Android
If you're going to use your activity, might as well replace the context
object that is automatically binded, otherwise you're wasting the space.
> A special variable named context is generated for use in binding > expressions as needed. The value for context is the Context from the > root View's getContext(). The context variable will be overridden by > an explicit variable declaration with that name.
binding.setContext(this);
and
<variable name="context" type="com.example.MyActivity"/>
Note if you just use plain string onClick="someFunc"
that's not a databinding functionality at all. That's an older feature that uses a little reflection to find the method on the context.
Solution 5 - Android
You should do
android:onClick="@{() -> handlers.onClickFriend()}"
Solution 6 - Android
I'm posting this just to cover both ways to achieve this.
- by Listener binding
- by method refernce
layout:
<layout...>
<data>
<variable
name="handlers"
type="com.example.databinding.MyPresenter" />
<variable name="user" type="com.example.databinding.User"/>
</data>
<LinearLayout
android:layout_width="wrap_content"
android:layout_height="wrap_content">
<Button
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="32dp"
android:text="Using Listener Binding"
android:onClick="@{() -> handlers.onLisClick(user)}"/>
<Button
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="32dp"
android:text="Using Method Ref"
android:onClick="@{handlers::onButtonClicked}"/>
</LinearLayout>
</layout>
Activity:
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
ActivityMainBinding binding =
DataBindingUtil.setContentView(this, R.layout.activity_main);
MyPresenter presenter = new MyPresenter();
User user = new User("Alex","RJ")
binding.setUser(user);
binding.setHandlers(presenter);
}
MyPresenter:
public class MyPresenter{
//using listener binding
public void onLisClick(User user){
//do something..
}
//using method reference
public void onButtonClicked(View view){
// do something
}
}
Note:
1.While using method reference the method signature should be same as you would write for any other onClick's method ie public and View as parameter.
2.While using listener binding you have benefit that you can directly pass the Object also if you want and do any operation.
Solution 7 - Android
It is not obligatory to create the separate class MyHandlers
and call setHandlers
for processing android:onClick
. You can just use the methods: public void onClickFriend(View view)
and public void onClickEnemy(View view)
in MainActivity
.
The activity view:
public class MainActivity extends AppCompatActivity {
User user;
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
ActivityMainBinding binding =
DataBindingUtil.setContentView(this, R.layout.activity_main);
user = new User("Pankaj", "Kumar", true, true);
binding.setUser(user);
}
public void onClickFriend(View view) {
Log.i(MyHandlers.class.getSimpleName(), "Now Friend");
}
public void onClickEnemy(View view) {
Log.i(MyHandlers.class.getSimpleName(), "Now Enemy");
}
}
A layout:
<data>
<import type="android.view.View"/>
<variable name="user" type="com.example.databinding.User"/>
</data>
<TextView
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@{user.firstName}"
android:visibility="@{user.isFriend ? View.VISIBLE : View.GONE}" />
<Button
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="Click Me"
android:id="@+id/button"
android:layout_gravity="left"
android:onClick="@{onClickFriend}"/>
Take a look at the example of using the Data Binding Library for the MVVM pattern: http://cases.azoft.com/mvvm-android-data-binding
Solution 8 - Android
I'm posting this because I've had an other situation in which this occurred. If you have two activities referencing to the Layout file and one defines the onclick event and the other doesn't you get the same warning and strangely in the activity where you defined the event.
To check this I recommend finding the usages of the layout file by right clicking
on the layout name and press find references
. Don't forget to rebuild the app afterwords.
Solution 9 - Android
> For those who are having trouble in handling long click events:
First create a view in your layout with an id.
<data>
<variable
name="tempDesc"
type="String" />
<variable
name="activity"
type="com.naruto.trangoapp.MainActivity" />
</data>
<TextView
android:id="@+id/textView"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:onClick="@{(view) -> activity.changeDescText(view)}"
android:text="@{tempDesc}" />
In your onCreate method use the id name of the view to set any listener:-
binding.textView.setOnLongClickListener(this::onLongClick);
then just create a boolean method with the same name, i.e., onLongClick like this:-
private boolean onLongClick(View l) {
Toast.makeText(this, "Description", Toast.LENGTH_SHORT).show();
return true;
}
That's all!!
Note: You can also set any method to any view in your layout by setting context to the activity variable in your onCreate method:-
binding.setActivity(this);
Then, define and pass the method name with view in your layout to use it in your Activity file. Like I have used a method changeDescText(v) with variable name "activity" for my Textview. Here is my method in Activity file:-
public void changeDescText(View view) {
binding.setTempDesc("Description Changed");
}