$(this) inside of AJAX success not working

Jquery

Jquery Problem Overview


I am trying to change some old code which uses onclick so that I an use the $(this). The problem is that $(this) is not working when inside the success. Is there anyway to do this without setting it as a var.

$('.addToCart').click(function() {
	
	$.ajax({
		url: 'cart/update',
		type: 'post',
		data: 'product_id=' + $(this).attr("data-id"),
		dataType: 'json',
		success: function(json) {
										
			if (json['success']) {
				
			$(this).addClass("test");
				
			}	
		}
	});
	
});

Jquery Solutions


Solution 1 - Jquery

Problem

Inside the callback, this refers to the jqXHR object of the Ajax call, not the element the event handler was bound to. Learn more about how this works in JavaScript.


Solutions

If ES2015+ is available to you, then using an arrow function would probably be the simplest option:

$.ajax({
    //...
    success: (json) => {
         // `this` refers to whatever `this` refers to outside the function
    }
});

You can set the context option:

> This object will be made the context of all Ajax-related callbacks. By default, the context is an object that represents the ajax settings used in the call ($.ajaxSettings merged with the settings passed to $.ajax). (...)

$.ajax({
    //...
    context: this,
    success: function(json) {
         // `this` refers to the value of `context`
    }
});

or use $.proxy:

$.ajax({
    //...
    success: $.proxy(function(json) {
         // `this` refers to the second argument of `$.proxy`
    }, this)
});

or keep a reference to the value of this outside the callback:

var element = this;

$.ajax({
    //...
    success: function(json) {
         // `this` refers to the jQXHR object
         // use `element` to refer to the DOM element
         // or `$(element)` to refer to the jQuery object
    }
});

Solution 2 - Jquery

jQuery(".custom-filter-options .sbHolder ul li a").each(function () {
    var myStr = jQuery(this).text();
    var myArr = myStr.split(" (");
     url = 'your url'; // New Code
            data = myArr[0];
                try {
                    jQuery.ajax({
                        url : url,
                        context: this,
                        type : 'post',
                        data : data,
                        success : function(data) {
			if(data){
     			  jQuery(this).html(data);
			}else{
			      jQuery(this).html(myArr[0]);
			}
                        }
                    });
                } catch (e) {
                } 
    
    
});

Attributions

All content for this solution is sourced from the original question on Stackoverflow.

The content on this page is licensed under the Attribution-ShareAlike 4.0 International (CC BY-SA 4.0) license.

Content TypeOriginal AuthorOriginal Content on Stackoverflow
QuestionJohn MagnoliaView Question on Stackoverflow
Solution 1 - JqueryFelix KlingView Answer on Stackoverflow
Solution 2 - JqueryVishal SanwarView Answer on Stackoverflow