How to select/comment on a range of lines in github pull request?
GithubPull RequestGithub Problem Overview
There is an option to comment on a range of lines in file on github, see https://stackoverflow.com/questions/18070876/how-to-refer-to-a-specific-line-or-range-of-lines-in-github/18072686
But is there similar option to comment on range of lines inside pull request?
When I click on line, only single line is highlighted yellow and R### (e.g. R446) is appended to url, clicking another line with shift pressed doesn't do anything. I tried to change url to R446-450 but it didn't do anything. Changing it to #L450-458 also didn't do anything. Also even that single highlighted line doesn't seem to affect anything.
Clicking blue plus that appears on hover creates comment window, but it only commenting on a single line.
Commenting on single line results in this
Comment on pull-request page shows only 4 lines above selected/commented line, but I'm interested in showing 7 lines, not 4
Github Solutions
Solution 1 - Github
Since Oct. 2019, Nat Friedman (CEO of GitHub) declares that feature available
(And, see below, since Feb. 2020, multi-lines comment reference is possible)
>
Multi-line comments are here!
Click and drag to comment on multiple lines in a pull request diff. ✨
> These little quality-of-life improvements are at the heart of what we love doing at GitHub. 殺
Nick Craver immediately asks:
> Follow-up question: are there plans to support suggestions?
It seems to apply to the last line at the moment:
That would be, according to Nat, "Coming early next year".
Update Feb. 2020: "A new interaction for multi-line pull request comments "
> To leave a comment referencing multiple lines, you can either:
> - click on a line number in the diff view, hold Shift, click on a second line number and click the "+" button next to the second line number; or
- click and hold to the right of a line number, drag and then release the mouse when you’ve reached the desired line.
This was announced by Nat Friedman
> Shipping today on GitHub: multi-line suggestions!
With, again, special thanks to Melanie Gilman, Pat Nakajima, Mike Chlipala, Joel Califa, John Caine, Matt Colyer and , and Kelly Arwine.
GitHub Changelog also references this.
Henry adds an observation
> A smaller side effect, but I assume being able to share a multi-line diff in the PR is new too!
Example: babel/babel PR 10511 diff-L261-L263
But that was available since July 2019
Solution 2 - Github
It isn't possible to comment on multiple lines in a pull request review at GitHub. I hope they will create a new feature where this is possible.
But what you can do, there is a little (time consuming) workaround:
If you go in to the code, in the branch with the changes, you can select multiple lines and then copy a permalink for those lines. When you paste this link into your review comment, it will be shown as a code snippet.
For more, read this: https://help.github.com/articles/creating-a-permanent-link-to-a-code-snippet/
Update Github has released a new feature where this is possible. See VonC's answer :-)
Solution 3 - Github
To reference multiple lines click on a line number in the diff view, hold shift, and click on a second line number. The URL of the page will update and can be shared with fellow contributors.
To leave a comment referencing multiple lines click and hold to the right of a line number, drag, and then release the mouse when you’ve reached the desired line.
Solution 4 - Github
The multiline comment feature is now available on GitHub. Enjoy!
Solution 5 - Github
Multi-line comments have arrived! Git has introduced new feature today for multiline comment please have look
By click on + icon and then drag to multiple lines